On Wed, 4 Aug 2010, Michael Grzeschik wrote: > On Wed, Aug 04, 2010 at 11:55:39AM +0200, Guennadi Liakhovetski wrote: > > On Tue, 3 Aug 2010, Michael Grzeschik wrote: > > > > > In the current source status the emma has no limitation for any PIXFMT > > > since the data is parsed raw and unprocessed into the memory. > > > > I'd like some explanation for this one too, please. What about > > > > + /* > > + * We only use the EMMA engine to get rid of the broken > > + * DMA Engine. No color space consversion at the moment. > > + * We adjust incoming and outgoing pixelformat to rgb16 > > + * and adjust the bytesperline accordingly. > > + */ > > + writel(PRP_CNTL_CH1EN | > > + PRP_CNTL_CSIEN | > > + PRP_CNTL_DATA_IN_RGB16 | > > + PRP_CNTL_CH1_OUT_RGB16 | > > + PRP_CNTL_CH1_LEN | > > + PRP_CNTL_CH1BYP | > > + PRP_CNTL_CH1_TSKIP(0) | > > + PRP_CNTL_IN_TSKIP(0), > > + pcdev->base_emma + PRP_CNTL); > > + > > + writel(((bytesperline >> 1) << 16) | icd->user_height, > > + pcdev->base_emma + PRP_SRC_FRAME_SIZE); > > + writel(((bytesperline >> 1) << 16) | icd->user_height, > > + pcdev->base_emma + PRP_CH1_OUT_IMAGE_SIZE); > > + writel(bytesperline, > > + pcdev->base_emma + PRP_DEST_CH1_LINE_STRIDE); > > + writel(0x2ca00565, /* RGB565 */ > > + pcdev->base_emma + PRP_SRC_PIXEL_FORMAT_CNTL); > > + writel(0x2ca00565, /* RGB565 */ > > + pcdev->base_emma + PRP_CH1_PIXEL_FORMAT_CNTL); > > > > To me it looks like the eMMA is configured for RGB565. What's the trick? > > > > Yes, it seems to be an indication, but the emma currently does not touch > any pixels, since the SRC_PIXEL_FORMAT and CH1_PIXEL_FORMAT are > identical. It will be needed in the future when we are going to do some > resizing operations with the emma or the SRC_PIXEL_FORMAT will differ to > the output channels. But at that time, the simple condition check for > RGB565 wouldn't be enough. So we should better remove them now. Then at least, please fix the above comment: > > + * We adjust incoming and outgoing pixelformat to rgb16 > > + * and adjust the bytesperline accordingly. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
