Hi, On 9/12/22 13:44, Andy Shevchenko wrote: > On Sun, Sep 11, 2022 at 07:16:36PM +0200, Hans de Goede wrote: >> Hi All, >> >> Here is another atomisp patch-series with further cleanups / unwanted code >> removal. Note this mostly cleaning up things which I hit while I'm still >> working towards converting the driver to videobuf2. >> >> The main goal of this series was to make the atomisp locking more like >> that of other v4l2 drivers, which is acomplished in the >> "media: atomisp: Use video_dev.lock for ioctl locking" patch. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > for non-commented/non-authored-by-me patches. Thank you for all the reviews. I'm currently preparing a pull-req for atomisp for Mauro. You can find this series here now: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp For the indentation fixes you asked about for 16/17, see: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/commit/?h=media-atomisp&id=f9c9e7db01caaa1c1fa5a18d1505676c1bdcaeb0 Note I'm going to do a test-build + some quick local tests for this and then I'll put a signed-tag on it and send out a pull-req. So if you are still going to give your Reviewed-by for patch 1 + 16 it will likely be too late for me to process the tags, sorry. Regards, Hans > >> Andy Shevchenko (1): >> media: atomisp_gmin_platform: Unexport and split camera_sensor_csi() >> >> Hans de Goede (16): >> media: atomisp: Use a normal mutex for the main lock >> media: atomisp: Remove unused lock member from struct >> atomisp_sub_device >> media: atomisp: Fix locking around asd->streaming read/write >> media: atomisp: Remove asd == NULL checks from ioctl handling >> media: atomisp: Add atomisp_pipe_check() helper >> media: atomisp: Remove watchdog timer >> media: atomisp: Move atomisp_streaming_count() check into >> __atomisp_css_recover() >> media: atomisp: Rework asd->streaming state update in >> __atomisp_streamoff() >> media: atomisp: Drop streamoff_mutex >> media: atomisp: Use video_dev.lock for ioctl locking >> media: atomisp: Remove a couple of not useful function wrappers >> media: atomisp: Drop unnecessary first_streamoff check >> media: atomisp: Make atomisp_set_raw_buffer_bitmap() static >> media: atomisp: Remove unused atomisp_css_get_dis_statistics() >> media: atomisp: Remove const/fixed camera_caps >> media: atomisp: Remove atomisp_source_pad_to_stream_id() >> >> .../include/linux/atomisp_gmin_platform.h | 2 - >> .../atomisp/include/linux/atomisp_platform.h | 18 - >> .../staging/media/atomisp/pci/atomisp_cmd.c | 581 ++---------------- >> .../staging/media/atomisp/pci/atomisp_cmd.h | 9 +- >> .../media/atomisp/pci/atomisp_compat.h | 4 - >> .../media/atomisp/pci/atomisp_compat_css20.c | 74 +-- >> .../staging/media/atomisp/pci/atomisp_fops.c | 87 +-- >> .../media/atomisp/pci/atomisp_gmin_platform.c | 86 ++- >> .../media/atomisp/pci/atomisp_internal.h | 39 +- >> .../staging/media/atomisp/pci/atomisp_ioctl.c | 567 ++++------------- >> .../staging/media/atomisp/pci/atomisp_ioctl.h | 10 +- >> .../media/atomisp/pci/atomisp_subdev.c | 34 +- >> .../media/atomisp/pci/atomisp_subdev.h | 24 +- >> .../staging/media/atomisp/pci/atomisp_v4l2.c | 65 +- >> 14 files changed, 267 insertions(+), 1333 deletions(-) >> >> -- >> 2.37.3 >> >
