Re: [RFC/PATCH v3 1/7] v4l: Share code between video_usercopy and video_ioctl2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Wednesday 04 August 2010 20:30:06 Hans Verkuil wrote:
> On Monday 12 July 2010 17:25:46 Laurent Pinchart wrote:
> > The two functions are mostly identical. They handle the copy_from_user
> > and copy_to_user operations related with V4L2 ioctls and call the real
> > ioctl handler.
> > 
> > Create a __video_usercopy function that implements the core of
> > video_usercopy and video_ioctl2, and call that function from both.
> 
> Acked-by: Hans Verkuil <hverkuil@xxxxxxxxx>

Thanks for the acks.

> Two notes:
> 
> 1) This change will clash with the multiplane patches.

Obviously, for this patch and the others, I will keep rebasing the code until 
it gets merged.

> 2) Perhaps it is time that we remove the __OLD_VIDIOC_ support?

Fine with me. We need to list that in feature-removal-schedule.txt.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux