Hi Rafael, On Sun 18 Sep 22, 23:32, Rafael Mendonca wrote: > The V4L2 fwnode data structure doesn't get freed on unbind, which leads to > a memleak. Thanks for this patch, good catch! I agree with Jacopo, you shouldn't add a newline before the call. Feel free to send a v2 with that fixed and include my: Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> Cheers, Paul > Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor") > Signed-off-by: Rafael Mendonca <rafaelmendsr@xxxxxxxxx> > --- > drivers/media/i2c/ov5648.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c > index dfcd33e9ee13..95850f06112b 100644 > --- a/drivers/media/i2c/ov5648.c > +++ b/drivers/media/i2c/ov5648.c > @@ -2598,6 +2598,8 @@ static int ov5648_remove(struct i2c_client *client) > mutex_destroy(&sensor->mutex); > media_entity_cleanup(&subdev->entity); > > + v4l2_fwnode_endpoint_free(&sensor->endpoint); > + > return 0; > } > > -- > 2.34.1 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature