Hi Laurent,
On Tue, Sep 20, 2022 at 01:18:36AM +0300, Laurent Pinchart wrote:
> On Tue, Sep 20, 2022 at 01:16:41AM +0300, Sakari Ailus wrote:
> > Runtime PM has been around for a decade or more, there's hardly a need to
> > use the V4L2 specific s_power() callback in drivers anymore. Document this
> > in s_power() callback documentation as well.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > include/media/v4l2-subdev.h | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index 2f80c9c818ed0..54566d139da79 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -176,7 +176,10 @@ struct v4l2_subdev_io_pin_config {
> > * @s_register: callback for VIDIOC_DBG_S_REGISTER() ioctl handler code.
> > *
> > * @s_power: puts subdevice in power saving mode (on == 0) or normal operation
> > - * mode (on == 1).
> > + * mode (on == 1). DEPRECATED. See
> > + * Documentation/driver-api/media/camera-sensor.rst . pre_streamon and
>
> Extra space before '.'
That's intended. It's easier to select that way.
>
> > + * post_streamoff callbacks can be used for e.g. setting the bus to LP-11
> > + * mode before s_stream is called.
>
> Technically post_streamoff doesn't really match that description, but
> that's OK.
Hopefully we can remove this soon... there seem to be 26 users left under
drivers/media and most of them are camera sensor drivers.
>
> > *
> > * @interrupt_service_routine: Called by the bridge chip's interrupt service
> > * handler, when an interrupt status has be raised due to this subdev,
>
--
Regards,
Sakari Ailus
