Hi Laurent,
On Mon, Sep 19, 2022 at 01:37:03PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Mon, Sep 19, 2022 at 01:10:04PM +0300, Sakari Ailus wrote:
> > Runtime PM has been around for a decade or more, there's hardly a need to
> > use the V4L2 specific s_power() callback in drivers anymore. Document this
> > in s_power() callback documentation as well.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > include/media/v4l2-subdev.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index 2f80c9c818ed0..ed14ce5864cac 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -176,7 +176,8 @@ struct v4l2_subdev_io_pin_config {
> > * @s_register: callback for VIDIOC_DBG_S_REGISTER() ioctl handler code.
> > *
> > * @s_power: puts subdevice in power saving mode (on == 0) or normal operation
> > - * mode (on == 1).
> > + * mode (on == 1). DEPRECATED. See
> > + * Documentation/driver-api/media/camera-sensor.rst .
>
> Could you mention that pre_streamon/post_streamoff cover the use case of
> bus initialization ? s_stream is commonly used for that purpose. With
> that,
I'll add:
pre_streamon and post_streamoff callbacks can be used for e.g. setting the
bus to LP-11 mode before s_stream is called.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks!
--
Sakari Ailus
