> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: 08 September 2022 20:41 > To: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>; 'Krzysztof Kozlowski' > <krzysztof.kozlowski@xxxxxxxxxx>; 'Smitha T Murthy' > <smitha.t@xxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx > Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx; > mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > ezequiel@xxxxxxxxxxxxxxxxxxxx; jernej.skrabec@xxxxxxxxx; > benjamin.gaignard@xxxxxxxxxxxxx; stanimir.varbanov@xxxxxxxxxx; > dillon.minfei@xxxxxxxxx; david.plowman@xxxxxxxxxxxxxxx; > mark.rutland@xxxxxxx; robh+dt@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > andi@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx > Subject: Re: [Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT > schema for MFC > > On 08/09/2022 14:56, Aakarsh Jain wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > >> Sent: 07 September 2022 16:52 > >> To: Smitha T Murthy <smitha.t@xxxxxxxxxxx>; linux-arm- > >> kernel@xxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > >> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > >> Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx; > >> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > >> ezequiel@xxxxxxxxxxxxxxxxxxxx; jernej.skrabec@xxxxxxxxx; > >> benjamin.gaignard@xxxxxxxxxxxxx; stanimir.varbanov@xxxxxxxxxx; > >> dillon.minfei@xxxxxxxxx; david.plowman@xxxxxxxxxxxxxxx; > >> mark.rutland@xxxxxxx; robh+dt@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > >> andi@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > aswani.reddy@xxxxxxxxxxx; > >> pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; > >> aakarsh.jain@xxxxxxxxxxx > >> Subject: Re: [Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT > >> schema for MFC > >> > >> On 07/09/2022 08:47, Smitha T Murthy wrote: > >>> Adds DT schema for s5p-mfc in yaml format > >> > >> s/Adds/Convert/ > >> (as convert to DT schema) > >> > > ok, I will change. > > > >> Please mention here changes to original binding (I see at least > >> adding iommus and dropping some properties). > >> > > ok. I will make this changes. > >>> > >>> Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx> > >>> Signed-off-by: Smitha T Murthy <smitha.t@xxxxxxxxxxx> > >>> --- > >>> .../devicetree/bindings/media/s5p-mfc.txt | 77 +------------ > >>> .../bindings/media/samsung,s5p-mfc.yaml | 109 > >> ++++++++++++++++++ > >>> 2 files changed, 110 insertions(+), 76 deletions(-) create mode > >>> 100644 Documentation/devicetree/bindings/media/samsung,s5p- > mfc.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt > >>> b/Documentation/devicetree/bindings/media/s5p-mfc.txt > >>> index aa54c8159d9f..0b7c4dd40095 100644 > >>> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt > >>> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt > >>> @@ -1,76 +1 @@ > >>> -* Samsung Multi Format Codec (MFC) > >>> - > >>> -Multi Format Codec (MFC) is the IP present in Samsung SoCs which > >>> -supports high resolution decoding and encoding functionalities. > >>> -The MFC device driver is a v4l2 driver which can encode/decode > >>> -video raw/elementary streams and has support for all popular -video > codecs. > >>> - > >>> -Required properties: > >>> - - compatible : value should be either one among the following > >>> - (a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs > >>> - (b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs > >>> - (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC > >>> - (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC > >>> - (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 > >> SoC > >>> - (f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC > >>> - > >>> - - reg : Physical base address of the IP registers and length of memory > >>> - mapped region. > >>> - > >>> - - interrupts : MFC interrupt number to the CPU. > >>> - - clocks : from common clock binding: handle to mfc clock. > >>> - - clock-names : from common clock binding: must contain "mfc", > >>> - corresponding to entry in the clocks property. > >>> - > >>> -Optional properties: > >>> - - power-domains : power-domain property defined with a phandle > >>> - to respective power domain. > >>> - - memory-region : from reserved memory binding: phandles to two > >> reserved > >>> - memory regions, first is for "left" mfc memory bus interfaces, > >>> - second if for the "right" mfc memory bus, used when no SYSMMU > >>> - support is available; used only by MFC v5 present in Exynos4 SoCs > >>> - > >>> -Obsolete properties: > >>> - - samsung,mfc-r, samsung,mfc-l : support removed, please use > >>> memory- > >> region > >>> - property instead > >> > >> When did they become obsolete? Is it enough of time to remove them? > > > > these properties were there earlier, we didn't added them in obsolete > properties. > > This is not the answer to my question. Is it enough of time to remove > deprecated properties? > sorry I misunderstood. These two mfc-l and mfc-r are still used in mfcv5 version as they use MFC_NUM_PORTS as 2, so we cannot make them obsolete yet. In next patch series we will add allOf: if: else: conditions for all the properties of each compatible string. Thanks for the review. > > > Best regards, > Krzysztof
