Hi Mikhail, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on robh/for-next krzk-dt/for-next linus/master v6.0-rc5 next-20220909] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mikhail-Rudenko/Add-Omnivision-OV4689-image-sensor-driver/20220912-040337 base: git://linuxtv.org/media_tree.git master config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220912/202209120637.Ypw3tniN-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/7c4d2965802d2be20badfef953b1d6f0d13d718f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mikhail-Rudenko/Add-Omnivision-OV4689-image-sensor-driver/20220912-040337 git checkout 7c4d2965802d2be20badfef953b1d6f0d13d718f # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/i2c/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/media/i2c/ov4689.c:112:28: warning: 'ov4689_global_regs' defined but not used [-Wunused-const-variable=] 112 | static const struct regval ov4689_global_regs[] = { | ^~~~~~~~~~~~~~~~~~ vim +/ov4689_global_regs +112 drivers/media/i2c/ov4689.c 108 109 /* 110 * Xclk 24Mhz 111 */ > 112 static const struct regval ov4689_global_regs[] = { 113 { REG_NULL, 0x00 }, 114 }; 115 -- 0-DAY CI Kernel Test Service https://01.org/lkp