Hi Irui, On 26/08/2022 11:28, Irui Wang wrote: > From: kyrie wu <kyrie.wu@xxxxxxxxxxxx> > > This series adds support for multi hardware jpeg decoding, > by first adding use of_platform_populate to manage each hardware > information: interrupt, clock, register bases and power. > Secondly add decoding work queue to deal with the decoding requests > of multi-hardware at the same time. Lastly, add output picture > reorder function interface to eliminate the out of order images. > > This series has been tested with both MT8195. > Decoding worked for this chip. When building this I get the following sparse warning and several kerneldoc warnings: SPARSE:drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c:661:24: warning: symbol 'mtk_jpegdec_hw_driver' was not declared. Should it be static? kerneldoc: WARNINGS drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:127: warning: Function parameter or member 'clks' not described in 'mtk_jpegdec_clk' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:127: warning: Function parameter or member 'clk_num' not described in 'mtk_jpegdec_clk' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:178: warning: Function parameter or member 'job_timeout_work' not described in 'mtk_jpegdec_comp_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:178: warning: Function parameter or member 'hw_param' not described in 'mtk_jpegdec_comp_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:178: warning: Function parameter or member 'hw_state' not described in 'mtk_jpegdec_comp_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:178: warning: Function parameter or member 'hw_lock' not described in 'mtk_jpegdec_comp_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:219: warning: Function parameter or member 'reg_decbase' not described in 'mtk_jpeg_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:219: warning: Function parameter or member 'dec_hw_dev' not described in 'mtk_jpeg_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:219: warning: Function parameter or member 'is_jpgdec_multihw' not described in 'mtk_jpeg_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:219: warning: Function parameter or member 'dec_hw_wq' not described in 'mtk_jpeg_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:219: warning: Function parameter or member 'dec_workqueue' not described in 'mtk_jpeg_dev' drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h:219: warning: Function parameter or member 'dechw_rdy' not described in 'mtk_jpeg_dev' Can you fix this in a v8? BTW, you can also choose to combine the jpeg encoder series with this series into one single series. I'll be merging them together anyway. That's up to you, though. Regards, Hans > > Patch 1 Adds jpeg decoder dt-bindings for mt8195 > > Patches 2 jpeg decoder builds three module for using Multi-HW, > export some functions to make them visible by other modules. > > Patch 3 use of_platform_populate to manage multi-hardware. > > Patch 4 add jpeg decoding timeout function to judge hardware timeout. > > Patch 5 add decoding work queue to deal with multi-hardware decoding > at the same time. > > Patch 6 add output picture reorder function to order images. > > Patch 7 refactor jpegdec func interface for HW working. > > Patch 8 add stop cmd function to deal with EOS operation. > > --- > This series patches dependent on: > media_stage tree: > [1] > https://git.linuxtv.org/media_stage.git/commit/?id=b3627647f9ea7473d10fb08a95fd7c4133a17ca4 > > patch1 new jpegdec dt-bindings included files > [2] MM IOMMU binding: > https://patchwork.kernel.org/project/linux-mediatek/patch/20220217113453.13658-2-yong.wu@xxxxxxxxxxxx/ > > [3] MT8195 power domain: > https://patchwork.kernel.org/project/linux-mediatek/list/?series=580579 > > Changes compared with v6: > - some modifications for patch v6's review comments. > > Changes compared with v5: > - some modifications for patch v5's review comments. > - fix yaml file check errors. > > Changes compared with v4: > - some modifications for patch v4's review comments. > - fix Gstreamer test errors. > > Changes compared with v3: > - some modifications for patch v3's review comments. > > Changes compared with v2: > - add stop cmd function. > - some modifications for patch v1's review comments. > > Changes compared with v1: > - new yaml file for mt8195 jpeg decoder. > - some modifications for patch v1's review comments. > > kyrie wu (8): > dt-bindings: mediatek: Add mediatek,mt8195-jpgdec compatible > media: mtk-jpegdec: export jpeg decoder functions > media: mtk-jpegdec: support jpegdec multi-hardware > media: mtk-jpegdec: add jpegdec timeout func interface > media: mtk-jpegdec: add jpeg decode worker interface > media: mtk-jpegdec: add output pic reorder interface > media: mtk-jpegdec: refactor jpegdec func interface > mtk-jpegdec: add stop cmd interface for jpgdec > > .../media/mediatek,mt8195-jpegdec.yaml | 169 ++++++++++ > drivers/media/platform/mediatek/jpeg/Makefile | 5 +- > .../platform/mediatek/jpeg/mtk_jpeg_core.c | 233 ++++++++++++- > .../platform/mediatek/jpeg/mtk_jpeg_core.h | 46 +++ > .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 314 ++++++++++++++++-- > .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.h | 3 +- > .../platform/mediatek/jpeg/mtk_jpeg_dec_reg.h | 1 + > 7 files changed, 739 insertions(+), 32 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml >
