On Thu, Sep 01, 2022 at 11:46:22AM +0200, Hans de Goede wrote: > Register /dev/* nodes at the end of atomisp_pci_probe(), this is > a prerequisite for dropping the loading mutex + ready flag kludge > for delaying open() calls on the /dev/* nodes . ... > for (; i > 0; i--) > atomisp_subdev_unregister_entities( > &isp->asd[i - 1]); This... > + for (i = 0; i < isp->num_of_streams; i++) { > + err = atomisp_subdev_register_video_nodes(&isp->asd[i], &isp->v4l2_dev); > + if (err) > + return err; > + } ...and this looks like a dup. Perhaps a helper? -- With Best Regards, Andy Shevchenko