> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 31 August 2022 16:20
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>; linux-
> media@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>;
> Biju Das <biju.das@xxxxxxxxxxxxxx>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: renesas,fcp:
> Document RZ/{G2,V2}L FCPVD bindings
>
> On 31/08/2022 17:37, Biju Das wrote:
> > Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to
> > FCP for VSP found on R-Car SoC's . It has 3 clocks compared to 1 clock
> > on fcpv. Introduce new compatibles renesas,r9a07g044-fcpvd for
> > RZ/G2{L,LC} and renesas,r9a07g054-fcpvd for RZ/V2L to handle this
> > difference.
> >
> > The 3 clocks are shared between du, vspd and fcpvd. Update the
> > bindings to reflect this.
> >
> > No driver changes are required as generic compatible string
> > "renesas,fcpv" will be used as a fallback.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v1->v2:
> > * Documented RZ/{G2,V2}L FCPVD bindings
> > * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd
> > * Added clock-names property
> > * described clocks.
> > ---
> > .../bindings/media/renesas,fcp.yaml | 46 +++++++++++++++++-
> -
> > 1 file changed, 41 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > index 43f2fed8cd33..79a55694b2a2 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > @@ -21,15 +21,23 @@ description: |
> >
> > properties:
> > compatible:
> > - enum:
> > - - renesas,fcpv # FCP for VSP
> > - - renesas,fcpf # FCP for FDP
> > + oneOf:
> > + - items:
>
> No items here. You have just one item, so it is not a list.
So you mean, it should be like below.
Can you please confirm my understanding is correct?
oneOf:
- enum:
- renesas,fcpv # FCP for VSP
- renesas,fcpf # FCP for FDP
- items:
- enum:
- renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
- renesas,r9a07g054-fcpvd # RZ/V2L
- const: renesas,fcpv # generic FCP for VSP fallback
> > + - renesas,fcpv # FCP for VSP
> > + - renesas,fcpf # FCP for FDP
>
> > + - enum:
> > + - renesas,fcpv # FCP for VSP
> > + - renesas,fcpf # FCP for FDP
> > +
> > + - items:
> > + - enum:
> > + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
> > + - renesas,r9a07g054-fcpvd # RZ/V2L
> > + - const: renesas,fcpv # generic FCP for VSP fallback
> >
> > reg:
> > maxItems: 1
> >
> > - clocks:
> > - maxItems: 1
> > + clocks: true
> > + clock-names: true
>
> Both should have here the widest constraints: minItems:1 and maxItems:3.
It is taken care in conditional schema right?
It is same as [1], where wider people including you added Rb tag.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20220831&id=17b5179ef6cd6430945c1da4174ceaf43c93cf1e
Cheers,
Biju
