Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.0-rc3 next-20220830] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Mugnier/media-Add-ST-VGXY61-camera-sensor-driver/20220830-201917 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dcf8e5633e2e69ad60b730ab5905608b756a032f config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220831/202208310250.RYcuxgtj-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6d33c014e63aa7c096d2ea01dd5e356ffef719d5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Benjamin-Mugnier/media-Add-ST-VGXY61-camera-sensor-driver/20220830-201917 git checkout 6d33c014e63aa7c096d2ea01dd5e356ffef719d5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/i2c/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/media/i2c/st-vgxy61.c: In function 'vgxy61_read_multiple': >> drivers/media/i2c/st-vgxy61.c:543:16: error: implicit declaration of function 'get_unaligned_le32' [-Werror=implicit-function-declaration] 543 | return get_unaligned_le32(val); | ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/get_unaligned_le32 +543 drivers/media/i2c/st-vgxy61.c 511 512 static int vgxy61_read_multiple(struct vgxy61_dev *sensor, u32 reg, 513 unsigned int len) 514 { 515 struct i2c_client *client = sensor->i2c_client; 516 struct i2c_msg msg[2]; 517 u8 buf[2]; 518 u8 val[sizeof(u32)] = {0}; 519 int ret; 520 521 if (len > sizeof(u32)) 522 return -EINVAL; 523 buf[0] = reg >> 8; 524 buf[1] = reg & 0xff; 525 526 msg[0].addr = client->addr; 527 msg[0].flags = client->flags; 528 msg[0].buf = buf; 529 msg[0].len = sizeof(buf); 530 531 msg[1].addr = client->addr; 532 msg[1].flags = client->flags | I2C_M_RD; 533 msg[1].buf = val; 534 msg[1].len = len; 535 536 ret = i2c_transfer(client->adapter, msg, 2); 537 if (ret < 0) { 538 dev_dbg(&client->dev, "%s: %x i2c_transfer, reg: %x => %d\n", 539 __func__, client->addr, reg, ret); 540 return ret; 541 } 542 > 543 return get_unaligned_le32(val); 544 } 545 -- 0-DAY CI Kernel Test Service https://01.org/lkp
