Hi Moudy, This series has now been merged in our tree, but I am getting new smatch errors, most likely due to the fact that I upgraded the gcc version I use from gcc-11.2 to gcc-12.2. I'm pretty sure that's the reason I didn't see these before. Can you take a look at this and post a follow-up patch? smatch: ERRORS drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:292 mdp_probe() error: we previously assumed 'mdp' could be null (see line 188) drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:872 mdp_comp_create() warn: passing devm_ allocated variable to kfree. 'comp' drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:460 mdp_cmdq_send() error: we previously assumed 'cmd' could be null (see line 369) Regards, Hans On 8/29/22 09:13, Hans Verkuil wrote: > > > The following changes since commit 1ff8334f0a4e0be693066aafba195d25629d77aa: > > media: MAINTAINERS: add entry for i.MX8MP DW100 v4l2 mem2mem driver (2022-08-21 08:42:26 +0200) > > are available in the Git repository at: > > git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.1c > > for you to fetch changes up to 56ef9c1c2a40f25e184712fbda5ae5b6900a3de1: > > media: platform: mtk-mdp3: add MediaTek MDP3 driver (2022-08-24 10:36:22 +0200) > > ---------------------------------------------------------------- > Tag branch > > ---------------------------------------------------------------- > Moudy Ho (3): > dt-binding: mediatek: add bindings for MediaTek MDP3 components > dt-binding: mediatek: add bindings for MediaTek CCORR and WDMA > media: platform: mtk-mdp3: add MediaTek MDP3 driver > > Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 95 ++++++ > Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 77 +++++ > Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 80 ++++++ > Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml | 68 +++++ > Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml | 81 ++++++ > drivers/media/platform/mediatek/Kconfig | 1 + > drivers/media/platform/mediatek/Makefile | 1 + > drivers/media/platform/mediatek/mdp3/Kconfig | 21 ++ > drivers/media/platform/mediatek/mdp3/Makefile | 6 + > drivers/media/platform/mediatek/mdp3/mdp_reg_ccorr.h | 19 ++ > drivers/media/platform/mediatek/mdp3/mdp_reg_rdma.h | 65 +++++ > drivers/media/platform/mediatek/mdp3/mdp_reg_rsz.h | 39 +++ > drivers/media/platform/mediatek/mdp3/mdp_reg_wdma.h | 47 +++ > drivers/media/platform/mediatek/mdp3/mdp_reg_wrot.h | 55 ++++ > drivers/media/platform/mediatek/mdp3/mtk-img-ipi.h | 290 +++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 466 ++++++++++++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.h | 43 +++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 1033 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h | 186 ++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 357 +++++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h | 94 ++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-m2m.c | 724 ++++++++++++++++++++++++++++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-m2m.h | 48 ++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.c | 735 +++++++++++++++++++++++++++++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h | 373 ++++++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c | 313 ++++++++++++++++++++ > drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.h | 78 +++++ > 27 files changed, 5395 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml > create mode 100644 drivers/media/platform/mediatek/mdp3/Kconfig > create mode 100644 drivers/media/platform/mediatek/mdp3/Makefile > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_ccorr.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_rdma.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_rsz.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_wdma.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_wrot.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-img-ipi.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-m2m.c > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-m2m.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.c > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c > create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.h