Hello, >Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: >Sylwester Nawrocki wrote: >> >> Add register definitions for the camera interface/video postprocessor >> contained in Samsung's S5P SoC series. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >> Reviewed-by: Pawel Osciak <p.osciak@xxxxxxxxxxx> >> Reviewed-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >> --- >> arch/arm/plat-samsung/include/plat/regs-fimc.h | 294 >> ++++++++++++++++++++++++ >> 1 files changed, 294 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/plat-samsung/include/plat/regs-fimc.h >> >> diff --git a/arch/arm/plat-samsung/include/plat/regs-fimc.h >b/arch/arm/plat- >> samsung/include/plat/regs-fimc.h >> new file mode 100644 >> index 0000000..7f3141c >> --- /dev/null >> +++ b/arch/arm/plat-samsung/include/plat/regs-fimc.h >> @@ -0,0 +1,294 @@ >> +/* arch/arm/plat-s5p/include/plat/regs-fimc.h >> + * >> + * Register definition file for Samsung Camera Interface (FIMC) driver <snip> > >Looks ok...however, I'm still thinking whether really need all these >definitions. > >Hmm... > Well, some of them are indeed unused, but it's not an uncommon practice in kernel and might help future developers. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
