On Mon, Aug 22, 2022 at 12:50 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> The atomisp code needs USERPTR pointers to be page aligned,
> otherwise bad things (scribbling over other parts of the
> process' RAM) happen.
>
> Add a check to ensure this and exit VIDIOC_QBUF calls with
> unaligned pointers with -EINVAL.
...
> if (buf->memory == V4L2_MEMORY_USERPTR) {
> + if (buf->m.userptr & ~PAGE_MASK) {
offset_in_page() ?
Further we may utilize helpers from pfn.h in the driver.
> + dev_err(isp->dev, "Error userptr is not page aligned.\n");
> + ret = -EINVAL;
> + goto error;
> + }
--
With Best Regards,
Andy Shevchenko
