Hi Dafna, On Thu, Aug 18, 2022 at 05:50:29AM +0300, Dafna Hirschfeld wrote: > On 17.08.2022 05:18, Laurent Pinchart wrote: > > The rkisp1_lsc_config() function incorrectly uses the > > RKISP1_CIF_ISP_LSC_SECT_SIZE() macro for the gradient registers. Replace > > it with the correct RKISP1_CIF_ISP_LSC_GRAD_SIZE() macro. This doesn't > > cause any functional change as the two macros are defined identically > > (the size and gradient registers store fields in the same number of bits > > at the same positions). > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > index aa6efa4c6e9e..421ade177b2d 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > @@ -334,7 +334,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params, > > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XSIZE(i), data); > > > > /* program x grad tables */ > > - data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->x_grad_tbl[i * 2], > > + data = RKISP1_CIF_ISP_LSC_GRAD_SIZE(arg->x_grad_tbl[i * 2], > > arg->x_grad_tbl[i * 2 + 1]); > > maybe the GRAD macro should change to: > > RKISP1_CIF_ISP_LSC_SECT_GRAD > > ? Good idea, I'll do that. > > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XGRAD(i), data); > > > > @@ -344,7 +344,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params, > > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YSIZE(i), data); > > > > /* program y grad tables */ > > - data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->y_grad_tbl[i * 2], > > + data = RKISP1_CIF_ISP_LSC_GRAD_SIZE(arg->y_grad_tbl[i * 2], > > arg->y_grad_tbl[i * 2 + 1]); > > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YGRAD(i), data); > > } -- Regards, Laurent Pinchart
