Re: [PATCH 2/5] media: rkisp1: Store LSC register values in u32 variables

[Dafna Hirschfeld <dafna@xxxxxxxxxxxx>]

On 17.08.2022 05:18, Laurent Pinchart wrote:
> Use the u32 type instead of unsigned int to store register values in the
> LSC configuration code, to make the variables' size more explicit. No
> functional change intended.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by: Dafna Hirschfeld <dafna@xxxxxxxxxxxx>

> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> index fbbaf5505291..dbe826fd02d2 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> @@ -199,7 +199,8 @@ rkisp1_lsc_matrix_config_v10(struct rkisp1_params *params,
> 			     const struct rkisp1_cif_isp_lsc_config *pconfig)
> {
> 	struct rkisp1_device *rkisp1 = params->rkisp1;
> -	unsigned int lsc_status, sram_addr, lsc_table_sel, i, j;
> +	u32 lsc_status, sram_addr, lsc_table_sel;
> +	unsigned int i, j;
>
> 	lsc_status = rkisp1_read(rkisp1, RKISP1_CIF_ISP_LSC_STATUS);
>
> @@ -258,7 +259,8 @@ rkisp1_lsc_matrix_config_v12(struct rkisp1_params *params,
> 			     const struct rkisp1_cif_isp_lsc_config *pconfig)
> {
> 	struct rkisp1_device *rkisp1 = params->rkisp1;
> -	unsigned int lsc_status, sram_addr, lsc_table_sel, i, j;
> +	u32 lsc_status, sram_addr, lsc_table_sel;
> +	unsigned int i, j;
>
> 	lsc_status = rkisp1_read(rkisp1, RKISP1_CIF_ISP_LSC_STATUS);
>
> @@ -316,8 +318,8 @@ static void rkisp1_lsc_config(struct rkisp1_params *params,
> 			      const struct rkisp1_cif_isp_lsc_config *arg)
> {
> 	struct rkisp1_device *rkisp1 = params->rkisp1;
> -	unsigned int i, data;
> -	u32 lsc_ctrl;
> +	u32 lsc_ctrl, data;
> +	unsigned int i;
>
> 	/* To config must be off , store the current status firstly */
> 	lsc_ctrl = rkisp1_read(rkisp1, RKISP1_CIF_ISP_LSC_CTRL);
> --
> Regards,
>
> Laurent Pinchart