Re: [PATCH] media: v4l2-ctrls: Fix typo in VP8 comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le jeudi 11 août 2022 à 13:37 -0700, Deborah Brouwer a écrit :
> The comment for the VP8 loop filter flags uses the partially wrong name
> for the flags. Unlike the other VP8 flag names, the loop filter flag names
> don't have "_FLAG" in them. Change the comment so that it matches the
> actual flag definitions in the header.

oops, perhaps it should have had that, but can't change it anymore.

Nice catch!

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
Fixes: 363240ce1c08 ("media: uapi: move VP8 stateless controls out of staging")


> 
> Signed-off-by: Deborah Brouwer <deborah.brouwer@xxxxxxxxxxxxx>
> ---
>  include/uapi/linux/v4l2-controls.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 5f46bf4a570c..a1363c59902d 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/
> 
> include/uapi/linux/v4l2-controls.h
> @@ -1730,7 +1730,7 @@ struct v4l2_vp8_segment {
>   * @sharpness_level: matches sharpness_level syntax element.
>   * @level: matches loop_filter_level syntax element.
>   * @padding: padding field. Should be zeroed by applications.
> - * @flags: see V4L2_VP8_LF_FLAG_{}.
> + * @flags: see V4L2_VP8_LF_{}.
>   *
>   * This structure contains loop filter related parameters.
>   * See the 'mb_lf_adjustments()' part of the frame header syntax,





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux