On Fri, 30 Jul 2010, Michael Grzeschik wrote:
> Signed-off-by: Philipp Wiesner <p.wiesner@xxxxxxxxx>
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
> drivers/media/video/mt9m111.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c
> index aeb2241..5f0c55e 100644
> --- a/drivers/media/video/mt9m111.c
> +++ b/drivers/media/video/mt9m111.c
> @@ -133,6 +133,10 @@
> #define MT9M111_MIN_DARK_COLS 24
> #define MT9M111_MAX_HEIGHT 1024
> #define MT9M111_MAX_WIDTH 1280
> +#define MT9M111_DEF_DARK_ROWS 12
> +#define MT9M111_DEF_DARK_COLS 30
> +#define MT9M111_DEF_HEIGHT 1024
> +#define MT9M111_DEF_WIDTH 1280
Don't think this split makes sense. Please, call them "DEFAUL": "DEF" is
too ambiguous, and unite with patch 08/20. In general, you're exaggerating
splitting og patches. Many of them make little sense with this kind of a
split and have to be merged.
>
> /* MT9M111 has only one fixed colorspace per pixelcode */
> struct mt9m111_datafmt {
> --
> 1.7.1
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
