From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> The optional operation can be used by entities to report whether a source pad and a sink pad are internally connected. media_entity_has_route() is a wrapper around the media entity has_route operation. Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> --- drivers/media/mc/mc-entity.c | 37 ++++++++++++++++++++++++++++++++++++ include/media/media-entity.h | 8 ++++++++ 2 files changed, 45 insertions(+) diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c index 50872d953cf9..4f02f1247762 100644 --- a/drivers/media/mc/mc-entity.c +++ b/drivers/media/mc/mc-entity.c @@ -225,6 +225,43 @@ EXPORT_SYMBOL_GPL(media_entity_pads_init); * Graph traversal */ +/** + * media_entity_has_route - Check if two entity pads are connected internally + * + * @entity: The entity + * @pad0: The first pad index + * @pad1: The second pad index + * + * This function uses the &media_entity_operations.has_route() operation to + * check connectivity inside the entity between @pad0 and @pad1. + * + * One of @pad0 and @pad1 must be a sink pad and the other one a source pad. + * The function returns 0 if both pads are sinks or sources. + * + * If the has_route operation is not implemented, all pads of the entity are + * considered as connected. + * + * The caller must hold entity->graph_obj.mdev->mutex. + * + * Return: true if the pads are connected internally and false otherwise. + */ +__maybe_unused +static bool media_entity_has_route(struct media_entity *entity, + unsigned int pad0, unsigned int pad1) +{ + if (pad0 >= entity->num_pads || pad1 >= entity->num_pads) + return false; + + if (entity->pads[pad0].flags & entity->pads[pad1].flags & + (MEDIA_PAD_FL_SINK | MEDIA_PAD_FL_SOURCE)) + return false; + + if (!entity->ops || !entity->ops->has_route) + return true; + + return entity->ops->has_route(entity, pad0, pad1); +} + static struct media_entity * media_entity_other(struct media_entity *entity, struct media_link *link) { diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 96f5fcda1985..5764aadd2c42 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -206,6 +206,12 @@ struct media_pad { * @link_validate: Return whether a link is valid from the entity point of * view. The media_pipeline_start() function * validates all links by calling this operation. Optional. + * @has_route: Return whether a route exists inside the entity between + * pad0 and pad1. pad0 and pad1 are guaranteed to not both + * be sinks or sources. Never call the .has_route() + * operation directly, always use media_entity_has_route(). + * Optional: If the operation isn't implemented all pads + * will be considered as connected, with the same streams. * * .. note:: * @@ -219,6 +225,8 @@ struct media_entity_operations { const struct media_pad *local, const struct media_pad *remote, u32 flags); int (*link_validate)(struct media_link *link); + bool (*has_route)(struct media_entity *entity, unsigned int pad0, + unsigned int pad1); }; /** -- 2.34.1