Em 29-07-2010 06:31, Guennadi Liakhovetski escreveu:
> Hi Mauro
>
> The following changes since commit c57fd88318988f17731e446fe1d8498f506fdd44:
>
> V4L/DVB: uvcvideo: Add support for Manta MM-353 Plako (2010-07-05 19:47:16 -0300)
>
> are available in the git repository at:
> git://linuxtv.org/gliakhovetski/v4l-dvb.git for-2.6.36
>
> Guennadi Liakhovetski (8):
> mediabus: fix ambiguous pixel code names
> V4L2: avoid name conflicts in macros
This patch is incomplete, as other macros use sd without declaring it
as an argument, like:
#define v4l2_device_call_all(v4l2_dev, grpid, o, f, args...) \
__v4l2_device_call_subdevs(v4l2_dev, \
!(grpid) || sd->grp_id == (grpid), o, f , ##args)
To make things even worse, some drivers have their own opinion about it, like:
#define cx18_call_hw(cx, hw, o, f, args...) \
__v4l2_device_call_subdevs(&(cx)->v4l2_dev, \
!(hw) || (sd->grp_id & (hw)), o, f , ##args)
The result is that this patch breaks the compilation on several drivers.
It is not your patch's fault. the problem is that those macros have something
to hide. If sd is a parameter of the macro, they should have being declaring
sd into their lists of arguments.
Please provide a version that will properly address those problems.
As the other patches don't seem to need this change (at least, all compiled
fine here), I'll drop this patch and apply the remaining ones.
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
