On Mon, 18 Jul 2022 02:42:13 +0100, Bryan O'Donoghue wrote:
> The yaml and driver we have right now misidentifies the imx577 as the
> imx412.
>
> Looking at similar IMX chips which give their chip identifier via register
> 0x0016 we can see:
>
> drivers/media/i2c/imx258.c:#define IMX258_REG_CHIP_ID 0x0016
> drivers/media/i2c/imx258.c:#define IMX258_CHIP_ID 0x0258
>
> drivers/media/i2c/imx319.c:#define IMX319_REG_CHIP_ID 0x0016
> drivers/media/i2c/imx319.c:#define IMX319_CHIP_ID 0x0319
>
> drivers/media/i2c/imx355.c:#define IMX355_REG_CHIP_ID 0x0016
> drivers/media/i2c/imx355.c:#define IMX355_CHIP_ID 0x0355
>
> Right now imx412.c does:
>
> drivers/media/i2c/imx412.c:#define IMX412_REG_ID 0x0016
> drivers/media/i2c/imx412.c:#define IMX412_ID 0x577
>
> As a first step to fixing this problem rename the supporting yaml file and
> containing text from imx412 to imx577.
>
> Fixes: 333b3125d130 ("media: dt-bindings: media: Add bindings for imx412")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> .../i2c/{sony,imx412.yaml => sony,imx577.yaml} | 18 +++++++++---------
> MAINTAINERS | 6 +++---
> 2 files changed, 12 insertions(+), 12 deletions(-)
> rename Documentation/devicetree/bindings/media/i2c/{sony,imx412.yaml => sony,imx577.yaml} (83%)
>
Acked-by: Rob Herring <robh@xxxxxxxxxx>
