Re: [PATCH] media: uvcvideo: fix a crash in uvc_ctrl_init_ctrl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 20, 2022 at 01:34:56AM +0300, Laurent Pinchart wrote:
> Hi Dan,
> 
> Thank you for the patch.
> 
> On Tue, Jul 19, 2022 at 04:45:29PM +0300, Dan Carpenter wrote:
> > There is a path where "mapping" is NULL when we try to process the
> > common mappings so it will crash.
> > 
> > Fixes: 86f7ef773156 ("media: uvcvideo: Add support for per-device control mapping overrides")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> I've submitted [1] to fix this issue, and [2] to replace all the
> error-prone loops in this function.
> 
> [1] https://lore.kernel.org/linux-media/20220718121219.16079-1-laurent.pinchart@xxxxxxxxxxxxxxxx/
> [2] https://lore.kernel.org/linux-media/20220718222757.8203-1-laurent.pinchart@xxxxxxxxxxxxxxxx/T/#u
> 

Ah, perfect.  Thank you!

regards,
dan carpenter

> > ---
> > This bug was previously reported by the kbuild bot and fixed in later
> > versions of the patchset.  The git log doesn't have a link to
> > lore.kernel.org but I suspect an earlier version got merged?




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux