Re: [PATCH 2/5] media: ov5647: Support HFLIP and VFLIP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jacopo,

Thanks for the set.

On Wed, Jun 15, 2022 at 05:14:54PM +0200, Jacopo Mondi wrote:
> From: David Plowman <david.plowman@xxxxxxxxxxxxxxx>
> 
> Add these missing V4L2 controls. Tested binned and full resolution
> modes in all four orientations using Raspberry Pi running libcamera.
> 
> Signed-off-by: David Plowman <david.plowman@xxxxxxxxxxxxxxx>
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
>  drivers/media/i2c/ov5647.c | 72 ++++++++++++++++++++++++++++++++++----
>  1 file changed, 66 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
> index 98b72094ef68..c292e5d09eab 100644
> --- a/drivers/media/i2c/ov5647.c
> +++ b/drivers/media/i2c/ov5647.c
> @@ -136,7 +140,7 @@ static struct regval_list ov5647_2592x1944_10bpp[] = {
>  	{0x3036, 0x69},
>  	{0x303c, 0x11},
>  	{0x3106, 0xf5},
> -	{0x3821, 0x06},
> +	{0x3821, 0x00},
>  	{0x3820, 0x00},

As you're setting the values through the control handler, the registers
should be removed from register lists.

>  	{0x3827, 0xec},
>  	{0x370c, 0x03},

-- 
Regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux