Hi Sakari,
On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
>
> The definition doesn't seem to be used here. Is there a need to include
> this?
There was, but the change that added bus-type to this binding got
reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
Revert DPI support") and I forgot to drop the header when rebasing.
> I could drop this chunk while applying. There's just one trivial change
> elsewhere in this patch to make.
Please do :-)
--
Regards,
Laurent Pinchart
