On Wed, Jul 13, 2022 at 10:41:01PM +0300, Sakari Ailus wrote: > On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote: > > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > Thank you for the patch. > > > > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > > > The config option text was recently removed, also remove the help text. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > > Actually, on second thought, isn't it useful to keep the help text as > > documentation ? > > We haven't generally done that for other such options either. This was > intended for end users IMO. I don't have a strong opinion, but this came to my attention when reviewing your patch that adds selection of GENERIC_PHY_MIPI_DPHY for sun6i. The GENERIC_PHY_MIPI_DPHY symbol isn't user-selectable but has a help text. A short documentation is useful in my opinion. -- Regards, Laurent Pinchart
