Il 05/07/22 14:56, AngeloGioacchino Del Regno ha scritto:
Il 27/06/22 04:56, Irui Wang ha scritto:
From: kyrie wu <kyrie.wu@xxxxxxxxxxxx>
This series adds support for multi hardware jpeg encoding, by first
adding use of_platform_populate to manage each hardware information:
interrupt, clock, register bases and power. Secondly add encoding
work queue to deal with the encoding requestsof multi-hardware
at the same time. Lastly, add output picture reorder function
interface to eliminate the out of order images.
This series has been tested with MT8195 Gstreamer.
Encoding worked for this chip.
Hello Irui,
Unfortunately, I can't reproduce your successful test with gstreamer: when
I try to encode a jpeg with videotestsrc input, I get a kernel panic.
To reproduce this behavior, please run the following:
gst-launch-1.0 videotestsrc ! v4l2jpegenc ! filesink location=hwenctest.jpg
Adding context: I've just discovered that this issue is due to a little overlook
in the probe function, which I've pointed out in the review for the specific patch
that's introducing the typo.
After fixing a one-liner, there's no more kernel panic, but another issue was
discovered regarding runtime PM:
[ 184.309766] mtk-jpeg soc:jpgenc_master: Runtime PM usage count underflow!
[ 184.317970] mtk-jpeg soc:jpgenc_master: Runtime PM usage count underflow!
[ 184.326128] mtk-jpeg soc:jpgenc_master: Runtime PM usage count underflow!
Here's the panic log:
[ 342.567211] Unable to handle kernel NULL pointer dereference at virtual address
0000000000000108
[ 342.576014] Mem abort info:
[ 342.578805] ESR = 0x0000000096000004
[ 342.582552] EC = 0x25: DABT (current EL), IL = 32 bits
[ 342.587863] SET = 0, FnV = 0
[ 342.590919] EA = 0, S1PTW = 0
[ 342.594062] FSC = 0x04: level 0 translation fault
[ 342.598941] Data abort info:
[ 342.601826] ISV = 0, ISS = 0x00000004
[ 342.605668] CM = 0, WnR = 0
[ 342.608643] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000119029000
[ 342.615094] [0000000000000108] pgd=0000000000000000, p4d=0000000000000000
[ 342.621907] Internal error: Oops: 96000004 [#1] SMP
[ 342.626800] Modules linked in: cdc_ether usbnet r8152 af_alg qrtr mt7921e
mt7921_common mt76_connac_lib mt76 mac80211 btusb btrtl btintel btmtk btbcm
bluetooth cfg80211 mtk_vcodec_dec_hw uvcvideo snd_sof_mt8195 ecdh_generic
mtk_vcodec_dec ecc mtk_adsp_common videobuf2_vmalloc snd_sof_xtensa_dsp rfkill
snd_sof_of v4l2_vp9 panfrost mtk_jpeg snd_sof v4l2_h264 mtk_jpeg_enc_hw 8021q
mtk_vcodec_common cros_ec_sensors gpu_sched cros_ec_lid_angle mtk_jpeg_dec_hw
hid_multitouch snd_sof_utils cros_ec_sensors_core crct10dif_ce garp
cros_usbpd_logger sbs_battery mrp stp llc ipmi_devintf ipmi_msghandler fuse ipv6
[ 342.680332] CPU: 3 PID: 180 Comm: kworker/u16:6 Tainted: G W
5.19.0-rc3-next-20220622+ #814
[ 342.689982] Hardware name: MediaTek Tomato (rev2) board (DT)
[ 342.695637] Workqueue: mtk-jpeg mtk_jpegenc_worker [mtk_jpeg]
[ 342.701402] pstate: 604000c9 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 342.708360] pc : mtk_jpegenc_worker+0x6c/0x3e0 [mtk_jpeg]
[ 342.713763] lr : mtk_jpegenc_worker+0x64/0x3e0 [mtk_jpeg]
[ 342.719166] sp : ffff8000093cbcd0
[ 342.722478] x29: ffff8000093cbcd0 x28: ffffb1f341cdb000 x27: ffff6089885d0505
[ 342.729618] x26: ffffb1f341ce1ee0 x25: ffffb1f341d0a2d0 x24: ffff60899078d000
[ 342.736758] x23: ffffb1f2e869c590 x22: ffff608990785458 x21: ffff60898a0ea120
[ 342.743898] x20: ffff60898a0ea080 x19: ffff60898a0ea080 x18: 0000000000000000
[ 342.751038] x17: 0000000000000000 x16: ffffb1f3405a58c0 x15: 0000aaaac092a3d0
[ 342.758178] x14: 0000000000000000 x13: 0000000000000c5f x12: 071c71c71c71c71c
[ 342.765318] x11: 0000000000000c5f x10: 00000000000027a0 x9 : ffffb1f33f32ce9c
[ 342.772458] x8 : fefefefefefefeff x7 : 0000000000000018 x6 : ffffb1f2e8699804
[ 342.779597] x5 : 0000000000000000 x4 : 0000000000000001 x3 : ffff608985d3c570
[ 342.786737] x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000
[ 342.793876] Call trace:
[ 342.796319] mtk_jpegenc_worker+0x6c/0x3e0 [mtk_jpeg]
[ 342.801376] process_one_work+0x294/0x664
[ 342.805392] worker_thread+0x7c/0x45c
[ 342.809055] kthread+0x104/0x110
[ 342.812283] ret_from_fork+0x10/0x20
[ 342.815863] Code: aa1503e0 9400037e f9415662 aa0003e1 (b9410840)
[ 342.821956] ---[ end trace 0000000000000000 ]---
Regards,
Angelo
