Hi Dafna, On Fri, Jul 01, 2022 at 08:22:22AM +0300, Dafna Hirschfeld wrote: > On 15.06.2022 04:11, Paul Elder wrote: > > The rkisp1 can take an input on the parallel interface. Add a port for > > it, and update the required field. At least one port is required, and > > both may be specified. > > > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > > --- > > .../bindings/media/rockchip-isp1.yaml | 23 +++++++++++++++++-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > index d1489b177331..b3661d7d4357 100644 > > --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > @@ -84,8 +84,27 @@ properties: > > minItems: 1 > > maxItems: 4 > > > > - required: > > - - port@0 > > + port@1: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: connection point for input on the parallel interface > > + > > + properties: > > + bus-type: > > + enum: [5, 6] > > + > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + required: > > + - bus-type > > + > > + anyOf: > > + - required: > > + - port@0 > > + - required: > > + - port@1 > > > > required: > > - compatible > > Could be nice to add an example I don't have a real-life example of a parallel sensor connected to a RK3399, but the i.MX8MP connects its CSI-2 receiver to the parallel input of the ISP. I'll add an example to the other DT bindings patch that adds the compatible string for the i.MX8MP, is that OK ? -- Regards, Laurent Pinchart
