Hi Benjamin, On Fri, Jun 17, 2022 at 01:58:01PM +0200, Benjamin Gaignard wrote: > Expose 10bit pixel formats to enable 10bit decoding in IMX8M SoCs. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx> Looks good to me. Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> Have you checked Fluster tests passess using both P010 and P010_4L4? It would be good to double-check. Thanks a lot, Ezequiel > --- > drivers/staging/media/hantro/imx8m_vpu_hw.c | 27 +++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/staging/media/hantro/imx8m_vpu_hw.c b/drivers/staging/media/hantro/imx8m_vpu_hw.c > index 77f574fdfa77..b390228fd3b4 100644 > --- a/drivers/staging/media/hantro/imx8m_vpu_hw.c > +++ b/drivers/staging/media/hantro/imx8m_vpu_hw.c > @@ -162,12 +162,39 @@ static const struct hantro_fmt imx8m_vpu_g2_postproc_fmts[] = { > .step_height = MB_DIM, > }, > }, > + { > + .fourcc = V4L2_PIX_FMT_P010, > + .codec_mode = HANTRO_MODE_NONE, > + .postprocessed = true, > + .frmsize = { > + .min_width = FMT_MIN_WIDTH, > + .max_width = FMT_UHD_WIDTH, > + .step_width = MB_DIM, > + .min_height = FMT_MIN_HEIGHT, > + .max_height = FMT_UHD_HEIGHT, > + .step_height = MB_DIM, > + }, > + }, > }; > > static const struct hantro_fmt imx8m_vpu_g2_dec_fmts[] = { > { > .fourcc = V4L2_PIX_FMT_NV12_4L4, > .codec_mode = HANTRO_MODE_NONE, > + .match_depth = true, > + .frmsize = { > + .min_width = FMT_MIN_WIDTH, > + .max_width = FMT_UHD_WIDTH, > + .step_width = TILE_MB_DIM, > + .min_height = FMT_MIN_HEIGHT, > + .max_height = FMT_UHD_HEIGHT, > + .step_height = TILE_MB_DIM, > + }, > + }, > + { > + .fourcc = V4L2_PIX_FMT_P010_4L4, > + .codec_mode = HANTRO_MODE_NONE, > + .match_depth = true, > .frmsize = { > .min_width = FMT_MIN_WIDTH, > .max_width = FMT_UHD_WIDTH, > -- > 2.32.0 >