Re: [PATCH] v4l2-ctl: Fix typo in --list-patterns help text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Umang,

Quoting Umang Jain (2022-06-27 18:14:18)
> s/stream-pattern/stream-out-pattern/
> 
> Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
> ---
>  utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp b/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
> index 7f6482d6..05de44d7 100644
> --- a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
> +++ b/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
> @@ -330,7 +330,7 @@ void streaming_usage()
>                "  --stream-out-dmabuf\n"
>                "                     output video using dmabuf [VIDIOC_(D)QBUF]\n"
>                "                     Requires a corresponding --stream-mmap option.\n"
> -              "  --list-patterns    list available patterns for use with --stream-pattern.\n"
> +              "  --list-patterns    list available patterns for use with --stream-out-pattern.\n"

At the least, according to `v4l2-ctl --help-all | grep -- -pattern` this
looks correct ...

>> $ v4l2-ctl --help-all | grep -- -pattern
>>   --stream-out-pattern <count>
>>   --list-patterns    list available patterns for use with --stream-pattern.

So 

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

>                "  --list-buffers     list all video buffers [VIDIOC_QUERYBUF]\n"
>                "  --list-buffers-out list all video output buffers [VIDIOC_QUERYBUF]\n"
>                "  --list-buffers-vbi list all VBI buffers [VIDIOC_QUERYBUF]\n"
> -- 
> 2.31.1
>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux