On Wed, Jun 29, 2022 at 05:36:31PM +0200, Hans Verkuil wrote: > drivers/staging/media/wave5/wave5-vpuapi.c:93 wave5_check_dec_open_param() warn: maybe use > && instead of & The warning is not clear but the bug looks real. if (!(BIT(param->bitstream_mode) & p_attr->support_bitstream_mode)) return -EINVAL; If this is really what you intended to write then it would be more readable as: if (!p_attr->support_bitstream_mode || param->bitstream_mode != BS_MODE_INTERRUPT) return -EINVAL; > drivers/staging/media/wave5/wave5-vpuapi.c:505 wave5_vpu_dec_get_output_info() warn: > inconsistent indenting Self explanatory. > drivers/staging/media/wave5/wave5-vpu-dec.c:1357 wave5_vpu_open_dec() warn: '&inst->list' > not removed from list Use after free. Probably the fix is to not call list_add_tail(&inst->list, &dev->instances) until everything succeeds. The others are hopefully self explanatory. regards, dan carpenter
