Hi Hans, On Wed, Jun 29, 2022 at 03:50:47PM +0200, Hans Verkuil wrote: > > @@ -585,8 +585,8 @@ static inline bool v4l2_is_hsv_enc_valid(__u8 hsv_enc) > > > > static inline bool v4l2_is_quant_valid(__u8 quantization) > > { > > - return quantization == V4L2_QUANTIZATION_FULL_RANGE || > > - quantization == V4L2_QUANTIZATION_LIM_RANGE; > > + return quantization > V4L2_QUANTIZATION_DEFAULT && > > + quantization < V4L2_QUANTIZATION_LAST; > > There are only two quantization ranges: full and limited. And I very sincerely > hope there will never be a third! For consistency of the checks and definitions I prefer it how it's in the patch. There's no functional difference though. -- Sakari Ailus