On Tue, Jul 27, 2010 at 10:24 PM, Jarod Wilson <jarod@xxxxxxxxxx> wrote:
> The ir_input_dev gets filled in by __ir_input_register, the one
> allocated in mceusb_init_input_dev was being overwritten by the correct
> one shortly after it was initialized (ultimately resulting in a memory
> leak). This bug was inherited from imon.c, and was pointed out to me by
> Maxim Levitsky.
D'oh, there's a minor errorlet in this patch...
> CC: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>
> ---
> drivers/media/IR/mceusb.c | 15 +--------------
> 1 files changed, 1 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/media/IR/mceusb.c b/drivers/media/IR/mceusb.c
> index 78bf7f7..9a7da32 100644
> --- a/drivers/media/IR/mceusb.c
> +++ b/drivers/media/IR/mceusb.c
> @@ -228,7 +228,6 @@ static struct usb_device_id std_tx_mask_list[] = {
> /* data structure for each usb transceiver */
> struct mceusb_dev {
> /* ir-core bits */
> - struct ir_input_dev *irdev;
> struct ir_dev_props *props;
> struct ir_raw_event rawir;
>
> @@ -739,7 +738,7 @@ static void mceusb_dev_recv(struct urb *urb, struct pt_regs *regs)
>
> if (ir->send_flags == RECV_FLAG_IN_PROGRESS) {
> ir->send_flags = SEND_FLAG_COMPLETE;
> - dev_dbg(&ir->irdev->dev, "setup answer received %d bytes\n",
> + dev_dbg(&ir->dev, "setup answer received %d bytes\n",
This should be dev_dbg(ir->dev, ... (i.e., without the ampersand).
Mauro, shall I resend this, or can you fix that at commit time?
--
Jarod Wilson
jarod@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
