On 6/27/22 14:53, Hugues FRUCHET wrote:
Hi Marek,
Hi,
Thanks for explanation, I understand now.
Please note that dcmi is not atmel-isi.c has same code structure, hence
same problem:
static int isi_try_fmt(struct atmel_isi *isi, struct v4l2_format *f,
struct v4l2_subdev_state pad_state = {
.pads = &pad_cfg
};
[...]
ret = v4l2_subdev_call(isi->entity.subdev, pad, set_fmt,
Moreover, searching for __v4l2_subdev_state_alloc() I see those "FIXME":
drivers/media/platform/renesas/vsp1/vsp1_entity.c
/*
* FIXME: Drop this call, drivers are not supposed to use
* __v4l2_subdev_state_alloc().
*/
entity->config = __v4l2_subdev_state_alloc(&entity->subdev,
"vsp1:config->lock", &key);
drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
/*
* FIXME: Drop this call, drivers are not supposed to use
* __v4l2_subdev_state_alloc().
*/
sd_state = __v4l2_subdev_state_alloc(sd, "rvin:state->lock", &key);
So I wonder about introducing this new change in dcmi while it is marked
as "FIXME" in other camera interface drivers ?
This is probably something Tomi/Laurent can answer better. It should be
OK for this driver as far as I understand the discussion in this thread.
