Re: [PATCH 36/55] media: rkisp1: isp: Rename rkisp1_get_remote_source()

[Dafna Hirschfeld <dafna@xxxxxxxxxxxx>]

On 15.06.2022 04:11, Paul Elder wrote:
> From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Rename the rkisp1_get_remote_source() function to
> rkisp1_isp_get_source() to use a consistent rkisp1_isp_* prefix for all
> ISP functions, and drop the "remote" as the source can't be local.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by Dafna Hirschfeld <dafna@xxxxxxxxxxxx>

> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> index 91b37f2dca91..627b1ad3bf26 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> @@ -58,7 +58,7 @@
>  * Helpers
>  */
>
> -static struct v4l2_subdev *rkisp1_get_remote_source(struct v4l2_subdev *sd)
> +static struct v4l2_subdev *rkisp1_isp_get_source(struct v4l2_subdev *sd)
> {
> 	struct media_pad *local, *remote;
> 	struct media_entity *sensor_me;
> @@ -754,7 +754,7 @@ static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable)
> 		return 0;
> 	}
>
> -	rkisp1->source = rkisp1_get_remote_source(sd);
> +	rkisp1->source = rkisp1_isp_get_source(sd);
> 	if (!rkisp1->source) {
> 		dev_warn(rkisp1->dev, "No link between isp and source\n");
> 		return -ENODEV;
> --
> 2.30.2