Re: Add support for v4l2_ctrl_modify_dimensions()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/06/2022 08:30, Xavier Roumegue (OSS) wrote:
> Hi Hans,
> 
> On 6/21/22 14:17, Hans Verkuil wrote:
>> Hi Xavier,
>>
>> I added support for v4l2_ctrl_modify_dimensions() to this branch:
>>
>> https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=array_mod
>>
>> It sits on top of the dynamic array control patches, which you already
>> have.
> Thanks for delivering this patch set so quickly.
>>
>> It's alpha quality and esp. request support hasn't been tested.
> I haven't noticed any issues, this works like a charm.
> I haven't tested request API as the dw100 driver does not really need its support.
>>
>> Let me know if this does what it needs to do, and then I'll clean
>> everything up and add more testing to v4l2-compliance.
> This fulfills well my need. Can I send an updated patch set with this wip API such as we could progress on the dw100 review while you are cleaning and finalizing this new control ?

Yes, as long as you clearly state in the cover letter of the patch series
that that the patches adding this are WIP.

Great to hear that it worked for you!

Regards,

	Hans

>>
>> Regards,
>>
>>     Hans
> Regards,
>  Xavier




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux