Hi Shuah, Thanks for the review. On Sat, Jun 18, 2022 at 5:01 AM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: > > On 6/16/22 7:57 PM, Yunke Cao wrote: > > Add a basic version of vimc lens. > > The lens supports V4L2_CID_FOCUS_ABSOLUTE control. > > Link the lens with vimc sensors using media-controller > > ancillary links. > > > > Commit log lines are usually ~75 charracters long. Make it easier > to read. That's good to know. Thanks! Should I send v3 and trim the commit log? I'm thinking something like this: The lens supports FOCUS_ABSOLUTE control. Link the lens with sensors using ancillary links. > > > This change can be used to test the recently added ancillary > > links. > > > > Care to add instructions on how one would test ancillary with > this feature? The lens shows up in the media topology. I documented it in 2/2. Not sure what else is necessary here. Best, Yunke > > > Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx> > > Signed-off-by: Yunke Cao <yunkec@xxxxxxxxxx> > > --- > > drivers/media/test-drivers/vimc/Makefile | 2 +- > > drivers/media/test-drivers/vimc/vimc-common.h | 1 + > > drivers/media/test-drivers/vimc/vimc-core.c | 86 +++++++++++---- > > drivers/media/test-drivers/vimc/vimc-lens.c | 102 ++++++++++++++++++ > > 4 files changed, 170 insertions(+), 21 deletions(-) > > create mode 100644 drivers/media/test-drivers/vimc/vimc-lens.c > > > > thanks, > -- Shuah
