Hello
On 17/06/2022 02:39, Yang Yingliang wrote:
> Add the missing clk_disable_unprepare() before return
> from ov7251_set_power_on() in the error handling case.
>
> Fixes: 9e1d3012cc10 ("media: i2c: Remove .s_power() from ov7251")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Thanks for spotting this - with Andy's comment addressed:
Reviewed-by: Daniel Scally <djrscally@xxxxxxxxx>
> ---
> drivers/media/i2c/ov7251.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c
> index 0e7be15bc20a..40c207d1d7af 100644
> --- a/drivers/media/i2c/ov7251.c
> +++ b/drivers/media/i2c/ov7251.c
> @@ -934,6 +934,7 @@ static int ov7251_set_power_on(struct device *dev)
> ARRAY_SIZE(ov7251_global_init_setting));
> if (ret < 0) {
> dev_err(ov7251->dev, "error during global init\n");
> + clk_disable_unprepare(ov7251->xclk);
> ov7251_regulators_disable(ov7251);
> return ret;
> }
