On Wed, 2010-07-28 at 12:42 -0300, Mauro Carvalho Chehab wrote: > Em 28-07-2010 11:53, Jon Smirl escreveu: > > On Wed, Jul 28, 2010 at 10:38 AM, Andy Walls <awalls@xxxxxxxxxxxxxxxx> wrote: > >> On Wed, 2010-07-28 at 09:46 -0400, Jon Smirl wrote: > > I recommend that all decoders initially follow the strict protocol > > rules. That will let us find bugs like this one in the ENE driver. > > Agreed. Well... I'd possibly make an exception for the protocols that have long-mark leaders. The actual long mark measurement can be far off from the protocol's specification and needs a larger tolerance (IMO). Only allowing 0.5 to 1.0 of a protocol time unit tolerance, for a protocol element that is 8 to 16 protocol time units long, doesn't make too much sense to me. If the remote has the basic protocol time unit off from our expectation, the error will likely be amplified in a long protocol elements and very much off our expectation. > I think that the better is to add some parameters, via sysfs, to relax the > rules at the current decoders, if needed. Is that worth the effort? It seems like only going half-way to an ultimate end state. <crazy idea> If you go through the effort of implementing fine grained controls (tweaking tolerances for this pulse type here or there), why not just implement a configurable decoding engine that takes as input: symbol definitions (pulse and space length specifications and tolerances) pulse train states allowed state transitions gap length decoded output data length and instantiates a decoder that follows a user-space provided specification? The user can write his own decoding engine specification in a text file, feed it into the kernel, and the kernel can implement it for him. </crazy idea> OK, maybe that is a little too much time and effort. ;) Regards, Andy > Cheers, > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
