Hi Shuah, Thanks for the review! I just sent out v2. Changelog from v1: -Better commit log. -A bit more detailed documentation in 2/2. On Thu, Jun 16, 2022 at 11:40 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: > > On 6/9/22 7:01 PM, Yunke Cao wrote: > > Add a basic version of vimc lens. > > Link lens with sensors using ancillary links. > > Update vimc documentation to reflect this change. > > > > Yunke Cao (2): > > media: vimc: add ancillary lens > > media: vimc: documentation for lens > > > > Documentation/admin-guide/media/vimc.dot | 4 + > > Documentation/admin-guide/media/vimc.rst | 3 + > > drivers/media/test-drivers/vimc/Makefile | 2 +- > > drivers/media/test-drivers/vimc/vimc-common.h | 1 + > > drivers/media/test-drivers/vimc/vimc-core.c | 86 +++++++++++---- > > drivers/media/test-drivers/vimc/vimc-lens.c | 102 ++++++++++++++++++ > > 6 files changed, 177 insertions(+), 21 deletions(-) > > create mode 100644 drivers/media/test-drivers/vimc/vimc-lens.c > > > > Reviewed all three patches > > Mauro, > > Would you like me to send a pull request for these patches? > > Yunke, please make sure to run get_maintainers.pl and include everybody > the scripts asks you to. Leaving out people causes delays in patch > reviews and acceptance. Thank you, I will do it in the future. Best, Yunke > > thanks, > -- Shuah
