Re: [Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 16, 2022 at 06:23:26AM +1000, Dave Airlie wrote:
> On Wed, 15 Jun 2022 at 20:53, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote:
> > > In tegra_uart_init(), of_find_matching_node() will return a node
> > > pointer with refcount incremented. We should use of_node_put()
> > > when it is not used anymore.
> > >
> > > Signed-off-by: heliang <windhl@xxxxxxx>
> >
> > We need a real name please, one you sign documents with.
> 
> How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

As per our rules in the kernel, we can not accept a signed-off-by by a
known anonymous person.  When you can obviously see that the name is
incorrect (as has happened recently with different names being used for
the from: and the s-o-b lines in the email address), you have to ask for
clarification.  It's something that all maintainers should be doing.

> What happens if that patch gets reposted, with S-o-b: He Liang
> <windhl@xxxxxxx> or Hel Iang, Heli Ang? Do you know any of those are
> real names? What happens if they post a real name in
> Mandarin/Thai/Cyrillic, can you validate it?

I would love for people to use their names in their native language,
there's no need to make up english-sounding names at all.  We have many
examples of this in commits already, I would be happy if we get more.

And yes, validating names in those languages is usually not very
difficult.

thanks,

greg k-h



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux