Hello Paul,
Am Dienstag, 14. Juni 2022, 21:10:42 CEST schrieb Paul Elder:
> From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> When a link validation failure occurs, print a debug message to help
> diagnosing the cause.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> .../media/platform/rockchip/rkisp1/rkisp1-capture.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c index
> 94819e6c23e2..94a0d787a312 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> @@ -1294,8 +1294,16 @@ static int rkisp1_capture_link_validate(struct
> media_link *link)
>
> if (sd_fmt.format.height != cap->pix.fmt.height ||
> sd_fmt.format.width != cap->pix.fmt.width ||
> - sd_fmt.format.code != fmt->mbus)
> + sd_fmt.format.code != fmt->mbus) {
> + dev_dbg(cap->rkisp1->dev,
I wonder if a dev_warn is more suitable here.
Best regards,
Alexander
> + "link '%s':%u -> '%s':%u not valid: 0x%04x/
%ux%u != 0x%04x/%ux%u",
> + link->source->entity->name, link->source-
>index,
> + link->sink->entity->name, link->sink->index,
> + sd_fmt.format.code, sd_fmt.format.width,
> + sd_fmt.format.height, fmt->mbus, cap-
>pix.fmt.width,
> + cap->pix.fmt.height);
> return -EPIPE;
> + }
>
> return 0;
> }
