On Mon, Jun 13, 2022 at 05:58:20PM +0300, Dan Carpenter wrote:
> On Sun, Jun 12, 2022 at 09:22:55PM +0200, Andy Shevchenko wrote:
> > > Note there is another patch in this series, which fixes the warning
> > > in another way.
> >
> > > Fixes: fa1451374ebf ("media: atomisp: don't pass a pointer to a local variable")
> >
> > Dunno for media subsystem, but for ones that Greg is maintain, the
> > point is that revert itself is already kinda fix and no need to have a
> > Fixes tag, instead the commit message should clearly have the
> > automatically generated line of revert (with the rest of the
> > explanation why that is needed). Just sharing my experience.
>
> How would that work in this case? We don't have a reference to the git
> hash.
What do you mean? `git revert` adds the hash of the commit being reverted.
> The `git revert` command came from early days of git and I always
> feel like it hasn't keep up with how git is used these days. The
> subject doesn't have the subsystem prefix. The commit message is wrong.
> It uses the full git hash instead of the 12 char hash. It doesn't have
> a fixes tag. Hans's commit is only correct because he re-wrote
> basically everything.
>
> Do a `git --grep=revert`. Some of them you can grep for "This reverts
> commit 8bdc2a190105e862dfe7a4033f2fd385b7e58ae8." but there are a lot
> which are not machine parsable
Why not? The format of the string hasn't been changed, no difference from other
patterns.
P.S. I have told this as my experience and what Greg told me, feel free to
discuss with him or others, I'm pretty much okay if Hans' patch goes as is.
--
With Best Regards,
Andy Shevchenko
