On Fri, May 27, 2022 at 02:29:53PM -0700, Kees Cook wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style of one-element or zero-length arrays should no > longer be used[2][3]. > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > [2] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays > [3] https://github.com/KSPP/linux/issues/78 > > Fixes: 9f599f351e86 ("media: amphion: add vpu core driver") > Cc: Ming Qian <ming.qian@xxxxxxx> > Cc: Shijie Qin <shijie.qin@xxxxxxx> > Cc: Zhou Peng <eagle.zhou@xxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Cc: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> Thanks -- Gustavo > --- > drivers/media/platform/amphion/vpu_dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/amphion/vpu_dbg.c b/drivers/media/platform/amphion/vpu_dbg.c > index da62bd718fb8..f72c8a506b22 100644 > --- a/drivers/media/platform/amphion/vpu_dbg.c > +++ b/drivers/media/platform/amphion/vpu_dbg.c > @@ -27,7 +27,7 @@ struct print_buf_desc { > u32 bytes; > u32 read; > u32 write; > - char buffer[0]; > + char buffer[]; > }; > > static char *vb2_stat_name[] = { > -- > 2.32.0 >
