Re: [PATCH] media: renesas: rcar_drif: Drop of_match_ptr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Laurent Pinchart (2022-05-25 10:20:54)
> The device_driver structure's of_match_table field exists
> unconditionally, so there's no need for of_match_ptr(). This fixes a
> compiler warning when test-compiling on non-OF platforms:
> 
> drivers/media/platform/renesas/rcar_drif.c:1470:34: warning: unused variable 'rcar_drif_of_table' [-Wunused-const-variable]
> static const struct of_device_id rcar_drif_of_table[] = {
>                                  ^
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/platform/renesas/rcar_drif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
> index 9a0982fa5c6b..5167960781bf 100644
> --- a/drivers/media/platform/renesas/rcar_drif.c
> +++ b/drivers/media/platform/renesas/rcar_drif.c
> @@ -1477,7 +1477,7 @@ MODULE_DEVICE_TABLE(of, rcar_drif_of_table);
>  static struct platform_driver rcar_drif_driver = {
>         .driver = {
>                 .name = RCAR_DRIF_DRV_NAME,
> -               .of_match_table = of_match_ptr(rcar_drif_of_table),
> +               .of_match_table = rcar_drif_of_table,
>                 .pm = &rcar_drif_pm_ops,
>                 },
>         .probe = rcar_drif_probe,
> 
> base-commit: 6c1c1eb8c87de221051b9198d40971640060842f
> -- 
> Regards,
> 
> Laurent Pinchart
>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux