Hi Sakari,
On Thursday 22 July 2010 19:30:21 Sakari Ailus wrote:
> Laurent Pinchart wrote:
> >>> +
> >>> +struct media_user_pad {
> >>> + __u32 entity; /* entity ID */
> >>> + __u8 index; /* pad index */
> >>> + __u32 direction; /* pad direction */
> >>> +};
> >>
> >> Another small comment, I think you mentioned it yourself some time back
> >>
> >> :-): how about some reserved fields to these structures?
> >
> > Very good point. Reserved fields are needed in media_user_entity and
> > media_user_links at least. For media_user_pad and media_user_link, we
> > could do without reserved fields if we add fields to media_user_links to
> > store the size of those structures.
>
> The structure size is part of the ioctl number defined by the _IOC macro
Not in this case, the ioctl uses a structure that stores pointers to the links
and pads arrays.
> so I'd go with reserved fields even for these structures. Otherwise
> special handling would be required for these ioctls in a few places.
A few reserved links would still be good, yes.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
