Re: [RFC/PATCH v2 01/10] media: Media device node support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Monday 26 July 2010 11:07:14 Laurent Pinchart wrote:
> Hi Hans,
> On Saturday 24 July 2010 13:59:11 Hans Verkuil wrote:
> > On Wednesday 21 July 2010 16:35:26 Laurent Pinchart wrote:
> > > The media_devnode structure provides support for registering and
> > > unregistering character devices using a dynamic major number. Reference
> > > counting is handled internally, making device drivers easier to write
> > > without having to solve the open/disconnect race condition issue over
> > > and over again.
> > > 
> > > The code is based on video/v4l2-dev.c.

[snip]

> > > +	mdev->dev.class = &media_class;
> > > +	mdev->dev.devt = MKDEV(MAJOR(media_dev_t), mdev->minor);
> > > +	mdev->dev.release = media_devnode_release;
> > > +	if (mdev->parent)
> > > +		mdev->dev.parent = mdev->parent;
> > > +	dev_set_name(&mdev->dev, "media%d", mdev->minor);
> > 
> > Wouldn't mediactlX be a better name? Just plain 'media' is awfully
> > general.
> 
> Good question.

Oops, I forgot to elaborate on that :-)

Plain "media" is indeed very generic. "mediactl" would be more specific, but 
I've never really liked the term "media controller". If you look at the media 
framework documentation, there's no reference to "controller" :-) I think it's 
"just" a media device.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux