Hi Hans, Thank you for your comment. I agree that this submission lacks documents sharing basic idea of the accelerators; what do they accept and what do they yield. Where can I put a new document? Can I put it as a comment in a source? Can I add a file under Documentation/misc-devices directory? Thanks, Yuji Ishikawa > -----Original Message----- > From: Hans Verkuil <hverkuil@xxxxxxxxx> > Sent: Thursday, May 12, 2022 8:15 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>; Sumit Semwal > <sumit.semwal@xxxxxxxxxx>; Christian König <christian.koenig@xxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-media@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; > linaro-mm-sig@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/4] Add Toshiba Visconti DNN image processing > accelerator driver > > Hi Yuji, > > On 4/28/22 15:11, Yuji Ishikawa wrote: > > This series is the DNN image processing accelerator driver for Toshiba's ARM > SoC, Visconti[0]. > > This provides DT binding documentation, device driver, MAINTAINER files. > > > > The second patch "soc: visconti: Add Toshiba Visconti image processing > accelerator common source" > > and the fourth patch "MAINTAINERS: ..." are the same as the ones in the > preceding post for affine driver. > > There appears to be no documentation whatsoever, unless I am missing > something. > > How is the uAPI supposed to be used? What does it do? What formats does it > accept or produce? > > If this processes images, then (as Laurent mentioned) this is more suitable as a > V4L2 mem2mem driver. > > See > https://linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/dev-me > m2mem.html > and the many drivers in drivers/media that use it (git grep v4l2-mem2mem.h). > > But without any explanation whatsoever I have no idea what does or does not > make sense. > > Regards, > > Hans > > > > > Best regards, > > Yuji > > > > [0]: > > > https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image- > > recognition-processors-visconti.html > > > > Yuji Ishikawa (4): > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > > accelerator bindings > > soc: visconti: Add Toshiba Visconti image processing accelerator > > common source > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > accelerator > > > > .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ > > MAINTAINERS | 2 + > > drivers/soc/Kconfig | 1 + > > drivers/soc/Makefile | 1 + > > drivers/soc/visconti/Kconfig | 7 + > > drivers/soc/visconti/Makefile | 8 + > > drivers/soc/visconti/dnn/Makefile | 6 + > > drivers/soc/visconti/dnn/dnn.c | 533 > ++++++++++++++++++ > > drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ > > drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ > > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ > > drivers/soc/visconti/ipa_common.c | 55 ++ > > drivers/soc/visconti/ipa_common.h | 18 + > > drivers/soc/visconti/uapi/dnn.h | 77 +++ > > drivers/soc/visconti/uapi/ipa.h | 88 +++ > > 15 files changed, 1329 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/visconti/toshiba,visconti-dnn.ya > > ml create mode 100644 drivers/soc/visconti/Kconfig create mode > > 100644 drivers/soc/visconti/Makefile create mode 100644 > > drivers/soc/visconti/dnn/Makefile create mode 100644 > > drivers/soc/visconti/dnn/dnn.c create mode 100644 > > drivers/soc/visconti/dnn/hwd_dnn.c > > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn.h > > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn_reg.h > > create mode 100644 drivers/soc/visconti/ipa_common.c create mode > > 100644 drivers/soc/visconti/ipa_common.h create mode 100644 > > drivers/soc/visconti/uapi/dnn.h create mode 100644 > > drivers/soc/visconti/uapi/ipa.h > >
