Re: [PATCH -next 2/3] [media] dm644x_ccdc: remove unnecessary check of res

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2022 at 3:53 AM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
>
> The resource is checked in probe function, so there is
> no need do this check in remove function.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>  drivers/media/platform/ti/davinci/dm644x_ccdc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/ti/davinci/dm644x_ccdc.c b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> index c6378c4e0074..e4073e99914c 100644
> --- a/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> +++ b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> @@ -839,8 +839,7 @@ static int dm644x_ccdc_remove(struct platform_device *pdev)
>
>         iounmap(ccdc_cfg.base_addr);
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       if (res)
> -               release_mem_region(res->start, resource_size(res));
> +       release_mem_region(res->start, resource_size(res));
>         vpfe_unregister_ccdc_device(&ccdc_hw_dev);
>         return 0;
>  }
> --
> 2.25.1
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux