> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, May 17, 2022 11:26 PM
> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>;
> Andrew Jeffery <andrew@xxxxxxxx>; Felipe Balbi <balbi@xxxxxxxxxx>; Sumit
> Semwal <sumit.semwal@xxxxxxxxxx>; Christian König
> <christian.koenig@xxxxxxx>; Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>;
> Li Yang <leoyang.li@xxxxxxx>
> Cc: linux-aspeed@xxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
> dri-devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm-sig@xxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller
> node
>
> On 17/05/2022 17:21, Neal Liu wrote:
> >>>>>
> >>>>> + udc: udc@1e6a2000 {
> >>>>
> >>>> The same as DTS in bindings - generic node name, please.
> >>>>
> >>>
> >>> Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between
> "vhub:
> >> usb-vhub@1e6a0000"?
> >>
> >> Possible yes :), but not recommended and not wanted. Nodes should be
> >> generic and prefixes are added only if there is no unit address. You
> >> can though use some more descriptive label.
> >>
> > "udc: usb@1e6a2000" is okay for you?
>
> Yes, it's perfect.
Great ! I'll update it for next patch.
Thanks for your suggestion.
>
>
> Best regards,
> Krzysztof
